Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management of buffered data exchange based on serializer defined in configuration #235

Merged
merged 6 commits into from
May 27, 2024
Merged

Management of buffered data exchange based on serializer defined in configuration #235

merged 6 commits into from
May 27, 2024

Conversation

masesdevelopers
Copy link
Collaborator

Description

This PR manages data exchange using ByteBuffer placing serializers in the KafkaDbContext properties

Related Issue

closed #232

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request KEFCore The issue is releated to KEFCore KEFCore SerDes The issue is releated to KEFCore SerDes .NET Pull requests that update .net code labels May 23, 2024
@masesdevelopers masesdevelopers self-assigned this May 23, 2024
@masesdevelopers masesdevelopers changed the title Management of buffered data exchange based on serializer used in configuration Management of buffered data exchange based on serializer defined in configuration May 23, 2024
masesdevelopers
masesdevelopers commented May 23, 2024
View reviewed changes
src/net/KEFCore.SerDes/KEFCoreSerDes.Helpers.cs Outdated Show resolved Hide resolved
test/Common/ProgramConfig.cs Outdated Show resolved Hide resolved
@masesdevelopers
Copy link
Collaborator Author

Comments in this PR shall be solved within KNet since most of serialization functionalities comes from that project

@masesdevelopers masesdevelopers mentioned this pull request May 23, 2024
Closed
@masesdevelopers masesdevelopers merged commit 7d4e6b5 into masesgroup:master May 27, 2024
4 checks passed
@masesdevelopers masesdevelopers deleted the 232-add-options-to-choose-betwee-n-buffered-and-non-buffered-data-exchange-both-on-key-and-value branch May 27, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@masesdevelopers masesdevelopers

Labels
enhancement New feature or request KEFCore SerDes The issue is releated to KEFCore SerDes KEFCore The issue is releated to KEFCore .NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to choose between buffered and non buffered data exchange both on key and value
1 participant
@masesdevelopers